LibWeb: Correct initiator origin logic for new top level traversables#8908
Open
jonbgamble wants to merge 1 commit intoLadybirdBrowser:masterfrom
Open
LibWeb: Correct initiator origin logic for new top level traversables#8908jonbgamble wants to merge 1 commit intoLadybirdBrowser:masterfrom
jonbgamble wants to merge 1 commit intoLadybirdBrowser:masterfrom
Conversation
jonbgamble
force-pushed
the
pr-document-state-origin
branch
2 times, most recently
from
9b2939d to
ead7cef
Compare
Contributor
|
Just noting so it doesn't get lost - the test added here failed in one of the runs: --- /home/runner/_work/ladybird/ladybird/Tests/LibWeb/Text/expected/./HTML/window-open-about-blank-inherits-opener-origin.txt
+++ /home/runner/_work/ladybird/ladybird/Tests/LibWeb/Text/expected/./HTML/window-open-about-blank-inherits-opener-origin.txt
@@ -1,3 +1,3 @@
initial popup.location.href: about:blank
initial popup.document.body.textContent: Hello Shannon!
-reloaded popup.document.body.textContent:
+reloaded popup.document.body.textContent: Hello Shannon! |
Contributor
Author
|
Nice one. I don't suppose I could blame this on Shannon? |
jonbgamble
force-pushed
the
pr-document-state-origin
branch
from
ead7cef to
cf9f0ed
Compare
gmta
reviewed
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.